[stubtest] Respect @final runtime decorator, enforce it in stubs#14922
Merged
sobolevn merged 2 commits intopython:masterfrom Mar 19, 2023
Merged
[stubtest] Respect @final runtime decorator, enforce it in stubs#14922sobolevn merged 2 commits intopython:masterfrom
@final runtime decorator, enforce it in stubs#14922sobolevn merged 2 commits intopython:masterfrom
Conversation
AlexWaygood
reviewed
Mar 18, 2023
AlexWaygood
reviewed
Mar 18, 2023
Member
There was a problem hiding this comment.
Also:
- Methods can also be decorated with
@final/@override, maybe we should also verify those in the same way? - We should add a comment next to this line, saying that we give a specialised error for classes decorated with
@finalelsewhere:
Line 1342 in 59886d2
Member
Author
|
@AlexWaygood I don't see much value in I will also work on Thanks a lot for the review, I am going to merge this when the CI is green 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14921